Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Mailer] Add Azure bridge #52842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2023
Merged

[Mailer] Add Azure bridge #52842

merged 1 commit into from
Dec 9, 2023

Conversation

hafael
Copy link
Contributor

@hafael hafael commented Dec 1, 2023 •
edited by OskarStark
Loading

Q A
Branch? 7.1
Bug fix? no
New feature? yes
Deprecations? no
Docs symfony/symfony-docs#19237
Recipe symfony/recipes#1265
License MIT

closes #52751

This PR adds a new mailer bridge for Azure Communication Services Email

@carsonbot carsonbot added this to the 7.1 milestone Dec 1, 2023
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "6.4".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@hafael hafael changed the base branch from 7.1 to 6.4 December 1, 2023 04:18
OskarStark
OskarStark approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you 🙏

If you like you can open a PR against symfony/symfony-docs and symfony/recipes, otherwise we can do it later

@hafael
Copy link
Contributor Author

hafael commented Dec 7, 2023 •
edited
Loading

Looks good to me, thank you 🙏

If you like you can open a PR against symfony/symfony-docs and symfony/recipes, otherwise we can do it later

Thanks @OskarStark ! Thanks for the reviews so far!

@OskarStark
Copy link
Contributor

Thanks @OskarStark ! Thanks for the reviews so far!

Thanks for your time ⏳

@OskarStark
Copy link
Contributor

Can you please rebase your PR?

@OskarStark
Copy link
Contributor

OskarStark commented Dec 8, 2023 •
edited
Loading

I added a docs and recipe PR

@OskarStark OskarStark mentioned this pull request Dec 8, 2023
Merged
@hafael hafael force-pushed the azure-mailer-bridge branch from 2d209d2 to c59963a Compare December 8, 2023 17:13
@hafael
Copy link
Contributor Author

hafael commented Dec 8, 2023

Can you please rebase your PR?

Done!

@hafael
Copy link
Contributor Author

hafael commented Dec 8, 2023

I added a docs and recipe PR

Thanks!

@fabpot
Copy link
Member

fabpot commented Dec 8, 2023

@hafael Can you rebase on 7.1, the first commit in this PR looks weird to me.

@hafael
Copy link
Contributor Author

hafael commented Dec 8, 2023

@hafael Can you rebase on 7.1, the first commit in this PR looks weird to me.

Sorry, I believe I didn't understand correctly. I believe this rebase has already been done. It could be a little more descriptive as I have some limitations with GIT.

@hafael hafael force-pushed the azure-mailer-bridge branch 2 times, most recently from c283bb4 to 39a162e Compare December 9, 2023 01:11
@hafael hafael requested a review from lyrixx as a code owner December 9, 2023 01:11
@hafael hafael force-pushed the azure-mailer-bridge branch from 39a162e to 311253f Compare December 9, 2023 01:14
@hafael
Copy link
Contributor Author

hafael commented Dec 9, 2023

@hafael Can you rebase on 7.1, the first commit in this PR looks weird to me.

done.

@fabpot fabpot force-pushed the azure-mailer-bridge branch from 311253f to dec3110 Compare December 9, 2023 11:05
@fabpot
Copy link
Member

fabpot commented Dec 9, 2023

Thank you @hafael.

@fabpot fabpot merged commit 088bd94 into symfony:7.1 Dec 9, 2023
@fabpot fabpot mentioned this pull request May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark OskarStark approved these changes

@nicolas-grekas nicolas-grekas Awaiting requested review from nicolas-grekas

@stof stof Awaiting requested review from stof

@lyrixx lyrixx Awaiting requested review from lyrixx

Assignees
No one assigned
Labels
Feature Mailer Status: Reviewed
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.

[Mailer] Add support for Azure Communication Services Email
4 participants
@hafael @carsonbot @OskarStark @fabpot