Use faster hashing algorithms when possible #52948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
reviewed
Dec 8, 2023
fabpot
approved these changes
Dec 9, 2023
|
@javiereguiluz Can you have a look at the tests as they seem to be broken by the changes made here. |
GromNaN
reviewed
Dec 9, 2023
| @@ -114,6 +114,6 @@ private function isNamedArguments(Node $arguments): bool | |||
|
|
|||
| private function getVarName(): string | |||
| { | |||
| return sprintf('__internal_%s', hash('sha256', uniqid(mt_rand(), true), false)); | |||
| return sprintf('__internal_%s', hash('xxh128', uniqid(mt_rand(), true))); | |||
There was a problem hiding this comment.
I don't think we need a random var name here. A global sequence would be enough to ensure there is no conflict.
Similar to what I did in https://github.com/twigphp/Twig/pull/3601/files#diff-47bc8653b21716576958e25b6d7356ecb0f0070f17554d12d2bee985ac211b26R59
|
Why not xxh3? (just asking for curiosity) |
GromNaN
approved these changes
Dec 10, 2023
In fact, where the hash is substr, |
|
I think it's better to use
|
|
Thank you @javiereguiluz. |
Merged
fabpot
added a commit
that referenced
this pull request
Jun 11, 2024
… namespace generation to the upgrade guide (mbabker) This PR was merged into the 7.1 branch. Discussion ---------- [Cache] Add a note about the change in the default cache namespace generation to the upgrade guide | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | N/A | License | MIT After deploying the Symfony 7.1 upgrade for a client, we immediately noticed a high rate of cache misses for one of our heavily used controller actions. Digging through the changes for the relevant upstream packages, it looks like this was introduced by way of #52948 and changing the algorithm used for the default cache namespaces when a `namespace` attribute isn't configured on the `cache.pool` service tag. To my knowledge, there is no way to configure a namespace for cache pools using the `framework.cache` configuration, so through the framework configuration, there is no way to avoid hitting this issue without either manually building cache services or getting creative with a compiler pass that runs before the core `CachePoolPass`, so IMO it's best to call out the change in the upgrade guide. Commits ------- f536f3c Add a note about the change in the default cache namespace generation to the upgrade guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xxh128is 60 times faster thansha256(source: https://php.watch/versions/8.1/xxHash) but it's not cryptographically secure.In previous versions we already used
xxh128in some places. In this PR I propose to use it in all places where we don't need a cryptographically secure hash.Comments:
I also remove someREVERTEDbase64encoding of binary hashes, etc. It looks convoluted and to me it looks unnecessary. But I can revert these changes if needed.xxh128but I'm not sure, so I didn't. These:#SymfonyHackday