allow Twig 4 #52989
Merged
allow Twig 4 #52989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Dec 11, 2023
| Q | A |
|---|---|
| Branch? | 7.1 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Issues | |
| License | MIT |
|
Why don't we target 6.4? |
I considered this change as a new feature. If we chose 6.4 as the target, then why not 5.4? |
|
Twig 4.x will probably never be released as is; this is "just" a branch that allows me to work on the next version that should be part of Symfony (7.1 hopefully). So, allowing it only on 7.1 for now works for me until we have a solid migration plan. |
We usually don't consider supporting new versions of 3rd party libraries as a new feature, but what @fabpot says makes sense to me. If Twig 4.x is a transitional branch that will eventually become symfony/twig 7.1, we should limit this change to the 7.1.x branch. |
chalasr
approved these changes
Dec 13, 2023
fabpot
approved these changes
Dec 17, 2023
|
Thank you @xabbuh. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.