[RateLimiter] Fix results on last token consume #53064
Open
+89
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is red, but I'm not sure that it related to my changes. |
666b407 to
cab4fab
Compare
cab4fab to
ac6348a
Compare
|
What is the status of this PR? Since half of the year nothing push it closer to live. |
|
@wouterj Can you have a look at this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a result of the discussion in PR #52835 (@wouterj)
It fixes wrong
retryAftervalues forfixed_windowandtoken_bucketpolicies and some related things.PS: Also seems there is one more bug with the
token_bucket- I'm sure that theTokenBucket::$timershould be used somehow in theRate::calculateTimeForTokens()- it calculates time fromnowat this moment.