[FrameworkBundle][RateLimiter] add rate_limiter tag to rate limiter services
#53091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rate_limiter tag to rate limiter servicesrate_limiter tag to rate limiter services
kbond
commented
Dec 15, 2023
| @@ -2860,7 +2860,8 @@ private function registerRateLimiterConfiguration(array $config, ContainerBuilde | |||
| // default configuration (when used by other DI extensions) | |||
| $limiterConfig += ['lock_factory' => 'lock.factory', 'cache_pool' => 'cache.rate_limiter']; | |||
|
|
|||
| $limiter = $container->setDefinition($limiterId = 'limiter.'.$name, new ChildDefinition('limiter')); | |||
| $limiter = $container->setDefinition($limiterId = 'limiter.'.$name, new ChildDefinition('limiter')) | |||
| ->addTag('rate_limiter', ['name' => $name]); | |||
There was a problem hiding this comment.
I think name is the standard tag index we use now or am I mistaken?
nicolas-grekas
approved these changes
Dec 19, 2023
fabpot
approved these changes
Dec 19, 2023
|
Thank you @kbond. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow creating tagged iterators/locators containing all registered rate limiters (indexed by their name).