Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Notifier] Add Unifonic notifier bridge #53092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2023
Merged

[Notifier] Add Unifonic notifier bridge #53092

merged 1 commit into from
Dec 17, 2023

Conversation

seferov
Copy link
Contributor

@seferov seferov commented Dec 15, 2023

Q A
Branch? 7.1
Bug fix? no
New feature? yes
Deprecations? no
Issues -
License MIT

@seferov seferov requested a review from OskarStark as a code owner December 15, 2023 21:23
@carsonbot carsonbot added this to the 7.1 milestone Dec 15, 2023
@seferov seferov force-pushed the notifier-unifonic branch 2 times, most recently from 08366b0 to 6ffa962 Compare December 15, 2023 21:31
OskarStark
OskarStark reviewed Dec 16, 2023
View reviewed changes
src/Symfony/Component/Notifier/Bridge/Unifonic/Tests/UnifonicTransportTest.php Outdated
Comment on lines 28 to 29
return (new UnifonicTransport('S3cr3t', 'Sender', $client ?? new MockHttpClient()))
->setHost($host);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return (new UnifonicTransport('S3cr3t', 'Sender', $client ?? new MockHttpClient()))
->setHost($host);
return (new UnifonicTransport('S3cr3t', 'Sender', $client ?? new MockHttpClient()))->setHost($host);

OskarStark
OskarStark reviewed Dec 16, 2023
View reviewed changes
src/Symfony/Component/Notifier/Bridge/Unifonic/Tests/UnifonicTransportTest.php Outdated

public function testSendSuccess()
{
$response = $this->createMock(ResponseInterface::class);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use MockResponse/JsonMockResponse instead?

OskarStark
OskarStark reviewed Dec 16, 2023
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, this is much appreciated. Please check my comments, thanks.

In parallel, we also need a PR against symfony/symfony-docs and symfony/recipes-contrib

This was referenced Dec 16, 2023
Merged
Merged
@fabpot
Copy link
Member

fabpot commented Dec 17, 2023

Thank you @seferov.

@fabpot fabpot merged commit 166d2d4 into symfony:7.1 Dec 17, 2023
@fabpot fabpot mentioned this pull request Dec 17, 2023
Closed
@fabpot fabpot mentioned this pull request May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Feature Notifier Status: Reviewed
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.
4 participants
@seferov @fabpot @OskarStark @carsonbot