Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Notifier] [Bluesky] Add default host #53094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[Notifier] [Bluesky] Add default host #53094

wants to merge 3 commits into from

Conversation

OskarStark
Copy link
Contributor

Q A
Branch? 7.1
Bug fix? no
New feature? yes
Deprecations? no
Issues Follows #53083
License MIT

@OskarStark OskarStark requested a review from Nyholm December 16, 2023 08:41
@carsonbot carsonbot added this to the 7.1 milestone Dec 16, 2023
@carsonbot carsonbot changed the title [Notifier][Bluesky] Add default host [Notifier] [Bluesky] Add default host Dec 16, 2023
@OskarStark OskarStark mentioned this pull request Dec 16, 2023
Merged
@Nyholm
Copy link
Member

Nyholm commented Dec 16, 2023

In the first draft of the Bluesky PR, I planned to do a Atproto version. But decided not to when I found the collection namespaces.

That is why I never cared for a default... since there are no default for Atproto.

My personal preference is (obviously) that this is not needed. This PR is just to "help" the user "bsky.socal" in the DSN.

@OskarStark
Copy link
Contributor Author

Thanks for the explanation

@OskarStark OskarStark closed this Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Awaiting requested review from Nyholm

Assignees
No one assigned
Labels
Feature Notifier Status: Needs Review
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.
3 participants
@OskarStark @Nyholm @carsonbot