[HttpKernel] Don't validate partially denormalized object #53107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 17, 2023
mtarld
approved these changes
Dec 18, 2023
src/Symfony/Component/HttpKernel/Controller/ArgumentResolver/RequestPayloadValueResolver.php
Show resolved
Hide resolved
|
Thank you @HypeMC. |
Merged
This was referenced Dec 30, 2023
Merged
Merged
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Jan 2, 2024
This PR was merged into the 5.4 branch. Discussion ---------- [Serializer] Fix using deserialization path 5.4 | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT I've noticed this while working on #53107. Sometimes, the `path` provided to the `NotNormalizableValueException` is incorrect. Commits ------- d498de7 [Serializer] Fix using deserialization path
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When one or more required constructor arguments are missing, the object is instantiated with
newInstanceWithoutConstructor():symfony/src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php
Lines 415 to 421 in 0af28a0
Since this means that all properties are empty, validating the entire object is unnecessary. This PR suggests avoiding the call to the validator when violations have already been identified through the
PartialDenormalizationException.