-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Serializer] Fix using deserialization path 5.4 #53108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Serializer] Fix using deserialization path 5.4 #53108
Conversation
809932d
to
3c07a87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, before that PR, paths related to constructor weren't taken into account. And it does look good to me to be more precise in that case
9194fa4
to
b7d9b29
Compare
Should we interpret this as an improvement then? For 7.1? |
@nicolas-grekas To me, this seems like a bug. As far as I can tell, the |
There's also the fact that the messages actually have the correct paths in them: [
...
- 'path' => null,
+ 'path' => 'string',
'message' => 'Failed to create object because the class misses the "string" property.',
], |
I agree with @HypeMC, it can be considered as a bugfix in my opinion |
b7d9b29
to
d498de7
Compare
Thank you @HypeMC. |
I've noticed this while working on #53107.
Sometimes, the
path
provided to theNotNormalizableValueException
is incorrect.