[VarDumper] Added default message for dd function #53123
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
Hey! Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "7.1 for features". Cheers! Carsonbot |
| @@ -49,6 +49,12 @@ function dd(mixed ...$vars): never | |||
| header('HTTP/1.1 500 Internal Server Error'); | |||
| } | |||
|
|
|||
| if (empty($vars)) { | |||
| VarDumper::dump('Dumped!'); | |||
There was a problem hiding this comment.
Should we use 🐛 like in the dump() function?
There was a problem hiding this comment.
It's not bug! So i think, we shouldn't use 🐛 this. We can use different emoji. What about 🐞 this? Or can you suggest something else?
There was a problem hiding this comment.
we should be consistent with what we do in dump:
VarDumper::dump(new ScalarStub('🐛'))de5def8 to
79ac231
Compare
5694cb5 to
857db8f
Compare
|
Thank you @shamimulalam. |
This will facilitate writing empty dd() statements during unorthodox debugging in the code. It will be helpful for both novice and experienced developers.