[HttpKernel] Add support for custom HTTP status code for the #[MapQueryParameter] attribute
#53209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
9db9710 to
cc784f6
Compare
src/Symfony/Component/HttpKernel/Controller/ArgumentResolver/QueryParameterValueResolver.php
Outdated
Show resolved
Hide resolved
cc784f6 to
94836b8
Compare
#[MapQueryParameter] attribute
OskarStark
reviewed
Dec 26, 2023
94836b8 to
454d3aa
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Dec 27, 2023
…colas-grekas) This PR was merged into the 7.1 branch. Discussion ---------- [HttpKernel] Add `HttpException::fromStatusCode()` | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | - | License | MIT A small helper idea that popped up when reviewing #53209 Commits ------- 98f4fa1 [HttpKernel] Add `HttpException::fromStatusCode()`
454d3aa to
c681fe2
Compare
nicolas-grekas
approved these changes
Dec 30, 2023
src/Symfony/Component/HttpKernel/Attribute/MapQueryParameter.php
Outdated
Show resolved
Hide resolved
…Parameter attribute
d33e181 to
c9f33bb
Compare
OskarStark
approved these changes
Jan 2, 2024
|
Thank you @ovidiuenache. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #52782 was created where the need to have a custom HTTP status code for the MapQueryParameter attribute was stated. As part of the discussion, @nicolas-grekas suggested an approach similar to the implementation of the MapQueryString attribute where such a status code can be provided in the attribute's constructor.
I believe having the possibility to control the status code returned for an invalid and non-nullable parameter with no default value would be a great addition so I took the liberty to create this PR.
This change is backward compatible.