Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Validator] support Stringable instances in CharsetValidator #53249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 28, 2023
Merged

[Validator] support Stringable instances in CharsetValidator #53249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Symfony/Component/Validator/Constraints/CharsetValidator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public function validate(mixed $value, Constraint $constraint): void
return;
}

if (!\is_string($value)) {
if (!\is_string($value) && !$value instanceof \Stringable) {
throw new UnexpectedValueException($value, 'string');
}

Expand Down
8 changes: 7 additions & 1 deletion src/Symfony/Component/Validator/Tests/Constraints/CharsetValidatorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ protected function createValidator(): CharsetValidator
/**
* @dataProvider provideValidValues
*/
public function testEncodingIsValid(string $value, array $encodings)
public function testEncodingIsValid(string|\Stringable $value, array $encodings)
{
$this->validator->validate($value, new Charset(encodings: $encodings));

Expand Down Expand Up @@ -66,6 +66,12 @@ public static function provideValidValues()
yield ['my ûtf 8', ['ASCII', 'UTF-8']];
yield ['my ûtf 8', ['UTF-8']];
yield ['string', ['ISO-8859-1']];
yield [new class() implements \Stringable {
public function __toString(): string
{
return 'my ûtf 8';
}
}, ['UTF-8']];
}

public static function provideInvalidValues()
Expand Down