[Validator] support \Stringable instances in all constraints
#53374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jan 3, 2024
| Q | A |
|---|---|
| Branch? | 7.1 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Issues | |
| License | MIT |
f118c4f to
68e0cc3
Compare
OskarStark
approved these changes
Jan 3, 2024
\Stringable instances in all constraints
68e0cc3 to
04bdd6c
Compare
GromNaN
reviewed
Jan 3, 2024
| @@ -36,7 +36,7 @@ public function validate(#[\SensitiveParameter] mixed $value, Constraint $constr | |||
| return; | |||
| } | |||
|
|
|||
| if (!\is_string($value)) { | |||
| if (!\is_string($value) && !$value instanceof \Stringable) { | |||
| throw new UnexpectedValueException($value, 'string'); | |||
| } | |||
| $passwordStrengthEstimator = $this->passwordStrengthEstimator ?? self::estimateStrength(...); | |||
There was a problem hiding this comment.
The value may be casted to (string) when calling $passwordStrengthEstimator($value). We don't know how this is handled by the $passwordStrengthEstimator callable.
GromNaN
approved these changes
Jan 3, 2024
|
It would be better with tests. |
04bdd6c to
05f9f45
Compare
|
@GromNaN tests added |
OskarStark
approved these changes
Jan 3, 2024
|
Thank you @xabbuh. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.