[Validator] Consistently use "This value is not" instead of "This is not" in error messages #53420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Jan 4, 2024
src/Symfony/Component/Validator/Resources/translations/validators.de.xlf
Outdated
Show resolved
Hide resolved
1e097ac to
a0676b3
Compare
GromNaN
reviewed
Jan 4, 2024
src/Symfony/Component/Validator/Resources/translations/validators.fr.xlf
Outdated
Show resolved
Hide resolved
Merged
0e0587a to
1205886
Compare
HypeMC
reviewed
Jan 5, 2024
src/Symfony/Component/Validator/Resources/translations/validators.hr.xlf
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Validator/Resources/translations/validators.hr.xlf
Outdated
Show resolved
Hide resolved
asispts
approved these changes
Jan 5, 2024
0960b22 to
dffe4fe
Compare
rosier
suggested changes
Jan 5, 2024
src/Symfony/Component/Validator/Resources/translations/validators.nl.xlf
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Validator/Resources/translations/validators.nl.xlf
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Validator/Resources/translations/validators.nl.xlf
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Validator/Resources/translations/validators.nl.xlf
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Validator/Resources/translations/validators.nl.xlf
Outdated
Show resolved
Hide resolved
d544484 to
3f4fe1f
Compare
|
PR rebased |
src/Symfony/Component/Validator/Resources/translations/validators.pl.xlf
Outdated
Show resolved
Hide resolved
3f4fe1f to
28316b0
Compare
|
@nicolas-grekas After #53444 we now need to update the source of |
…not" in error messages
28316b0 to
96c7fbd
Compare
updated! |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 23, 2024
…ffers from its resource name (nicolas-grekas) This PR was merged into the 5.4 branch. Discussion ---------- [Validator] Make it explicit when English translation differs from its resource name | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Inspired by #53505 Follows #53420 Commits ------- eaedae6 [Validator] Make it explicit when English translation differs from its resource name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's longer but more understandable. That's also how most messages are constructed already.
Related to #53417