[Validator] Add PHPDoc to GroupSequence attribute class and properties
#53428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GroupSequence attribute class and properties #53424GroupSequence attribute class and properties
OskarStark
reviewed
Jan 5, 2024
magikid
reviewed
Mar 5, 2024
Comment on lines
68
to
+69
| * | ||
| * If a class has a group sequence attached, that sequence replaces the | ||
| * "Default" group. When validating that class in the "Default" group, the | ||
| * group sequence is used instead, but still the "Default" group should be | ||
| * cascaded to other objects. | ||
| * @var string|GroupSequence |
There was a problem hiding this comment.
These two lines should be deleted to make the fabbot happy.
|
Let me close: this stalled and there's already a comprehensive phpdoc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds detailed PHPDoc comments to the GroupSequence class in the Symfony\Component\Validator\Constraints namespace. The added documentation includes a comprehensive class description and descriptive comments for each public property and the constructor.
These changes are in response to the issue #51920 and follow the same documentation style and standards as Symfony's existing components.