[Security] Fix AuthenticationUtils::getLastUsername() returning null
#53509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Jan 17, 2024
derrabus
approved these changes
Jan 17, 2024
xabbuh
reviewed
Jan 17, 2024
src/Symfony/Component/Security/Http/Tests/Authentication/AuthenticationUtilsTest.php
Outdated
Show resolved
Hide resolved
20bc78b to
2e52b06
Compare
xabbuh
approved these changes
Jan 18, 2024
|
déjà vu 🤔 #23409 |
chalasr
approved these changes
Jan 18, 2024
|
Thank you @alexandre-daubois. |
Merged
xabbuh
added a commit
that referenced
this pull request
Jan 19, 2024
This PR was merged into the 5.4 branch. Discussion ---------- [Security] fix tests | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT spotted while merging #53509 up where we added return types to the `AuthenticationUtils` methods Commits ------- c78f3e1 fix tests
This was referenced Jan 30, 2024
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can happen when the attribute is actually set with
null.Covered the class while at it.