Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Messenger] [AMQP] Throw exception on nack callback #53520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

[Messenger] [AMQP] Throw exception on nack callback #53520

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a46f124
fix: Throw exception on nack confirm callback
Jan 12, 2024
8a9ff13
chore: Adjust formatting for previously introduced exception message
kvrushifa Jan 12, 2024
33c3067
chore: Remove unused import
kvrushifa Jan 12, 2024
197afee
chore: Make psalm happy (hopefully)
kvrushifa Jan 12, 2024
972363a
refactor: Use correct exception class
kvrushifa Jan 12, 2024
2d13faa
chore: Write meaningful exception message
kvrushifa Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: Throw exception on nack confirm callback
  • Loading branch information
Nico Müller committed Jan 12, 2024
commit a46f12467100ba6012946422ca53afbfbd56535d
4 changes: 3 additions & 1 deletion src/Symfony/Component/Messenger/Bridge/Amqp/Transport/Connection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@

use Symfony\Component\Messenger\Exception\InvalidArgumentException;
use Symfony\Component\Messenger\Exception\LogicException;
use Symfony\Component\Messenger\Exception\RuntimeException;
use Symfony\Component\Messenger\Exception\SendingMessageFailedException;

/**
* An AMQP connection.
Expand Down Expand Up @@ -493,7 +495,7 @@ public function channel(): \AMQPChannel
$this->amqpChannel->confirmSelect();
$this->amqpChannel->setConfirmCallback(
static fn (): bool => false,
static fn (): bool => false
static fn (): bool => throw new RuntimeException('Confirm calls back with nack'),
);
}

Expand Down