[Messenger][Redis] Add option to auto generate consumer #53528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just asking, but wouldn't it be safer to add an option to the DSN |
This is technically possible. But since the consumer name is currently passed as path to the DSN, I think your approach wouldn't be intuitive because then two options/settings related to the consumer name would exist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I opened the above mentioned issue about 4 months ago.
In #53394 @AdamKatzDev , who seems to know a lot more about Redis than I do, also thinks that this is a good idea.
It looks like nobody has had a reason why this should not be a feature, so here it is.
Docs PR will be added when this looks good to merge.