Use {user_identifier} over deprecated {username} in factories
#53529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In SF 7.0, the deprecated {username} placeholder was removed in favor of {user_identifier} (in symfony#50866).
However, the default values for the filter and dn_string parameters still contained {username} instead of the updated key.
This PR changes the value to the new updated key
Signed-off-by: Thomas Citharel <[email protected]>
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
CI failure looks unrelated |
{user_identifier} over deprecated {username} in factories
fabpot
approved these changes
Jan 18, 2024
{user_identifier} over deprecated {username} in factories{user_identifier} over deprecated {username} in factories
|
Thank you @tcitworld. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SF 7.0, the deprecated
{username}placeholder was removed in favor of{user_identifier}(in #50866). However, the default values for thefilteranddn_stringparameters still contained{username}instead of the updated key.This PR changes the value to the new updated key