[Messenger] Use now function to allow mock of time
#53531
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing functional testing there is not really a easy way to mock the time for the `InMemoryTransport`. It's created by the `InMemoryTransportFactory` and you can't set which clock to use.
now function to allow mock of timenow function to allow mock of time
ro0NL
approved these changes
Jan 30, 2024
now function to allow mock of timenow function to allow mock of time
This comment was marked as resolved.
This comment was marked as resolved.
Yes, that is the best solution indeed |
derrabus
requested changes
Jan 30, 2024
now function to allow mock of timenow function to allow mock of time
I'd rather fix this aspect indeed: making the InMemoryTransportFactory accept and forward a clock. PR welcome. |
fabpot
added a commit
that referenced
this pull request
Apr 17, 2024
…MemoryTransport (xabbuh) This PR was merged into the 7.1 branch. Discussion ---------- [Messenger] forward a Clock instance to the created InMemoryTransport | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | Fix #53531 (comment) | License | MIT Commits ------- 1cfd8b5 forward a Clock instance to the created InMemoryTransport
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Apr 17, 2024
…MemoryTransport (xabbuh) This PR was merged into the 7.1 branch. Discussion ---------- [Messenger] forward a Clock instance to the created InMemoryTransport | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | Fix symfony/symfony#53531 (comment) | License | MIT Commits ------- 1cfd8b57e9 forward a Clock instance to the created InMemoryTransport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing functional testing there is not really a easy way to mock the time for the
InMemoryTransport. It's created by theInMemoryTransportFactoryand you can't set which clock to use.