Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Mailer][Webhook] Add MailerSend support #53583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

doobas
Copy link
Contributor

@doobas doobas commented Jan 19, 2024

Q A
Branch? 7.1
Bug fix? no
New feature? yes
Deprecations? no
License MIT

Support webhooks from MailerSend
MailerSend developers documentation

@carsonbot
Copy link

Hey!

To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done?

Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review.

Cheers!

Carsonbot

@doobas doobas marked this pull request as ready for review January 19, 2024 10:28
@carsonbot carsonbot added this to the 7.1 milestone Jan 19, 2024
@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "7.1 for features".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@carsonbot
Copy link

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot

@xabbuh
Copy link
Member

xabbuh commented Jan 19, 2024

You will also have to add symfony/webhook as a dev dependency to the MailerSend bridge's composer.json file.

@doobas doobas requested a review from xabbuh January 19, 2024 10:40
@doobas doobas requested a review from OskarStark January 22, 2024 09:45
@OskarStark OskarStark changed the title [Mailer][Webhook] Add MailerSend webhook support [Mailer][Webhook] Add MailerSend support Jan 22, 2024
protected function doParse(Request $request, #[\SensitiveParameter] string $secret): ?AbstractMailerEvent
{
if ($secret) {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This empty line should be removed

$content = $request->toArray();
if (
!isset($content['type'], $content['data']['email']['message']['id'], $content['data']['email']['recipient']['email'])
) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be all on one line

@fabpot
Copy link
Member

fabpot commented Feb 3, 2024

As I cannot push upstream, I've finished the work here: #53740

@fabpot fabpot closed this Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants