Adjusting and removing the 'review' attribute from the pt_br translion XML. #53639
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
| @@ -192,7 +192,7 @@ | |||
| </trans-unit> | |||
| <trans-unit id="51" resname="No temporary folder was configured in php.ini."> | |||
| <source>No temporary folder was configured in php.ini, or the configured folder does not exist.</source> | |||
| <target state="needs-review-translation">Não foi configurada uma pasta temporária no php.ini, ou a pasta configurada não existe.</target> | |||
| <target>Nenhum diretório temporário foi configurado no php.ini, ou o diretório configurado não existe.</target> | |||
There was a problem hiding this comment.
@xabbuh Yes, if it's an issue, I can revert this change. Upon reviewing it now, I think I might have made the change unnecessarily.
The intention was to make the sentence a bit more technical by replacing the word "pasta" (folder in english) with "diretório" (directory in english) and changing the negation and subject of the sentence to the beginning, making the sentence follow the subject-verb-object linguistic typology.
|
Thank you @epcgrs. |
| Branch? | 5.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Issues | Fix #53015
| License | MIT