[DoctrineBridge] Fix detection of Xml/Yaml driver in DoctrineExtension #53681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
e040afe to
baf1919
Compare
|
Thanks @GromNaN ! |
nicolas-grekas
approved these changes
Jan 30, 2024
src/Symfony/Bridge/Doctrine/DependencyInjection/AbstractDoctrineExtension.php
Outdated
Show resolved
Hide resolved
That's not necessary for |
37b2bb3 to
662b8f2
Compare
|
Thank you @GromNaN. |
MatTheCat
added a commit
to MatTheCat/symfony
that referenced
this pull request
Nov 5, 2024
nicolas-grekas
added a commit
that referenced
this pull request
Nov 6, 2024
… in DoctrineExtension (MatTheCat) This PR was merged into the 5.4 branch. Discussion ---------- [DoctrineBridge] Backport detection fix of Xml/Yaml driver in DoctrineExtension | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix doctrine/DoctrineBundle#1832 | License | MIT #53681 got merged on 6.4, but the DoctrinBundle still needs it on 5.4 😅 Commits ------- f7b61a2 [DoctrineBridge] Backport #53681
nicolas-grekas
added a commit
that referenced
this pull request
Nov 6, 2024
* 5.4: [DoctrineBridge] Backport #53681
nicolas-grekas
added a commit
that referenced
this pull request
Nov 6, 2024
* 6.4: [DoctrineBridge] Backport #53681
nicolas-grekas
added a commit
that referenced
this pull request
Nov 6, 2024
* 7.1: [DoctrineBridge] Backport #53681
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In DoctrineMongoDBBundle v5, we removed
.classattributes to plain class names in service definitions (see doctrine/DoctrineMongoDBBundle#821). The class fordoctrine_mongodb.odm.default_xml_metadata_driverchanged fromdoctrine_mongodb.odm.metadata.xml.classtoDoctrine\Bundle\MongoDBBundle\Mapping\Driver\XmlDriver.I fixed the detection of the driver by checking the uppercase
XmlandYamlbecause it might be necessary if the same change is made to DoctrineBundle.doctrine/mongodb-odm-bundlerequiressymfony/doctrine-bridge: "^6.4 || ^7.0"so this patch if not required for older versions of Symfony even if it could be applied.