[VarDumper] Add functional test for ServerDumpCommand
#53737
Conversation
e1f6536 to
0573d8d
Compare
|
@nicolas-grekas I tried to use DumpServer with the update in this PR and it allows testing ServerLogCommand. :) I wonder if it should be targeted 7.1 or 6.4 |
ServerDumpCommand
| [$data, $context] = $payload; | ||
|
|
||
| $callback($data, $context, $clientId); | ||
| $callback($clientId, $message); |
There was a problem hiding this comment.
that's a BC break as this changes the contract of the callback.
Also I'm not sure this makes sense it terms of responsibility.
There was a problem hiding this comment.
I did this following your comment in the PR #53518.
Do you have an idea ?
To help you, here a try of usage on the monolog bridge to see possibilities.
There was a problem hiding this comment.
I'm sorry we should try to keep the existing signature callback.
It's fine to me if we don't factorize the code with ServerLogCommand
The motivation for this PR is testing. Can't we do an integration test instead, where we start a real process?
0573d8d to
69e6ce6
Compare
|
@louismariegaborit What's the status of this PR? |
Update DumpServer to add functional test for the ServerDumpCommand.
This PR will allow to use DumpServer in the ServerLogCommand and test this command that had regressions in the past.
It's a try following a comment in another closed PR (#53518 (comment) cc @nicolas-grekas)