[ExpressionLanguage] Add more configurability to the parsing/linting methods #53806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
stof
reviewed
Feb 6, 2024
a4a7791 to
fc571b5
Compare
stof
reviewed
Feb 6, 2024
fc571b5 to
343551b
Compare
stof
approved these changes
Feb 6, 2024
343551b to
4ec7fdb
Compare
4ec7fdb to
c6182c0
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Feb 9, 2024
This PR was merged into the 7.1 branch. Discussion ---------- [SecurityBundle] Fix failing tests | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix CI | License | MIT After #53806 Commits ------- 31cf4f8 [SecurityBundle] Fix failing tests
symfony-splitter
pushed a commit
to symfony/security-bundle
that referenced
this pull request
Feb 9, 2024
This PR was merged into the 7.1 branch. Discussion ---------- [SecurityBundle] Fix failing tests | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix CI | License | MIT After symfony/symfony#53806 Commits ------- 31cf4f84a8 [SecurityBundle] Fix failing tests
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When linting/parsing an expression, two kinds of errors can be thrown: a syntax error (for which the parser cannot recover) or an unknown variable/function error (which does not block the parser).
When linting an expression, currently you can ignore unknown variables by passing
nullinstead of the valid variable names tolint()orparse(), but you cannot ignore unknown functions. For some use cases, it might be needed to just validate the syntax.This PR allows developers to ignore functions and/or variables the "proper way" with flags as a new argument to these methods:
Passing
nullto the$namesargument is deprecated:Before:
After: