Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Workflow] determines places from transitions #53866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2024

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Feb 8, 2024

Q A
Branch? 7.1
Bug fix? no
New feature? yes
Deprecations? no
Issues Fix #52378
License MIT

@carsonbot carsonbot added this to the 7.1 milestone Feb 8, 2024
@carsonbot carsonbot changed the title [workflow] determines places form transitions [Workflow] determines places form transitions Feb 8, 2024
@nicolas-grekas nicolas-grekas changed the title [Workflow] determines places form transitions [Workflow] determines places from transitions Feb 9, 2024
@nicolas-grekas
Copy link
Member

What about throwing if at least one place is defined?
The behavior would be:

  • if you don't define any place => auto-guessed from transitions
  • if you define at least one place => require them all to be listed (allowing some sort of strict mode definitions to be typo-safe)

@lyrixx
Copy link
Member Author

lyrixx commented Feb 9, 2024

The issues comes from the framework bundle. I want people to be able to

  • not define dumb places
  • define places with some metadata
framework:
    workflows:
        blog_publishing:
            metadata:
                title: 'Blog Publishing Workflow'
            places:
                draft:
                    metadata:
                        max_num_of_words: 500

            transitions:
                to_review:
                    from: draft
                    to:   review

@lyrixx lyrixx force-pushed the workflow-auto-places branch from 020b7d2 to ed30d81 Compare February 9, 2024 14:27
@lyrixx
Copy link
Member Author

lyrixx commented Feb 9, 2024

(fixed fabbot, phpunit failures seems not related)

@fabpot
Copy link
Member

fabpot commented Feb 11, 2024

Thank you @lyrixx.

@fabpot fabpot merged commit 0c362d2 into symfony:7.1 Feb 11, 2024
@lyrixx lyrixx deleted the workflow-auto-places branch February 12, 2024 09:23
@fabpot fabpot mentioned this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Workflow][RFC] Simplify workflow configuration
4 participants