Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Console] Add descriptions to Fish completion output #53986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2024
Merged

[Console] Add descriptions to Fish completion output #53986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/Symfony/Component/Console/Completion/Output/FishCompletionOutput.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,14 @@ class FishCompletionOutput implements CompletionOutputInterface
{
public function write(CompletionSuggestions $suggestions, OutputInterface $output): void
{
$values = $suggestions->getValueSuggestions();
$values = [];
foreach ($suggestions->getValueSuggestions() as $value) {
$values[] = $value->getValue().($value->getDescription() ? "\t".$value->getDescription() : '');
}
foreach ($suggestions->getOptionSuggestions() as $option) {
$values[] = '--'.$option->getName();
$values[] = '--'.$option->getName().($option->getDescription() ? "\t".$option->getDescription() : '');
if ($option->isNegatable()) {
$values[] = '--no-'.$option->getName();
$values[] = '--no-'.$option->getName().($option->getDescription() ? "\t".$option->getDescription() : '');
}
}
$output->write(implode("\n", $values));
Expand Down
6 changes: 1 addition & 5 deletions src/Symfony/Component/Console/Resources/completion.fish
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,7 @@ function _sf_{{ COMMAND_NAME }}

set completecmd $completecmd "-c$c"

set sfcomplete ($completecmd)

for i in $sfcomplete
echo $i
end
$completecmd
end

complete -c '{{ COMMAND_NAME }}' -a '(_sf_{{ COMMAND_NAME }})' -f
4 changes: 2 additions & 2 deletions src/Symfony/Component/Console/Tests/Completion/Output/FishCompletionOutputTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@ public function getCompletionOutput(): CompletionOutputInterface

public function getExpectedOptionsOutput(): string
{
return "--option1\n--negatable\n--no-negatable";
return "--option1\tFirst Option\n--negatable\tCan be negative\n--no-negatable\tCan be negative";
}

public function getExpectedValuesOutput(): string
{
return "Green\nRed\nYellow";
return "Green\tBeans are green\nRed\tRose are red\nYellow\tCanaries are yellow";
}
}