Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[ErrorHandler] debug test failures #54018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[ErrorHandler] debug test failures #54018

wants to merge 1 commit into from

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Feb 21, 2024

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

@xabbuh xabbuh requested a review from yceruto as a code owner February 21, 2024 09:36
@carsonbot carsonbot added this to the 5.4 milestone Feb 21, 2024
@xabbuh xabbuh force-pushed the error-handler-tests branch 4 times, most recently from 83008bd to 050fd02 Compare February 21, 2024 10:02
@xabbuh xabbuh force-pushed the error-handler-tests branch from 050fd02 to 5f700c6 Compare February 21, 2024 10:08
@nicolas-grekas
Copy link
Member

Looks like the workaround implemented in #40065 isn't needed anymore in PHP 8.3 (but we might need some other changes to make the test green)

@nicolas-grekas
Copy link
Member

Here's the fix! #54031

@xabbuh xabbuh deleted the error-handler-tests branch February 22, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

Assignees
No one assigned
Labels
ErrorHandler Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @nicolas-grekas @carsonbot