[HttpClient] Add support for amphp/http-client v5
#54179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1f32cb8 to
bf0ddb2
Compare
nicolas-grekas
commented
Mar 6, 2024
2357160 to
e18f2b9
Compare
e18f2b9 to
a5fb61c
Compare
nicolas-grekas
commented
Aug 16, 2024
There was a problem hiding this comment.
PR ready.
amphp/socket issue moved to amphp/socket#114
Status: needs review
|
Thank you @nicolas-grekas. |
amphp/http-client v5
It's still 8.1. Is it an issue? Shall we add logic to check the running PHP version ? |
|
We resolve this concern with https://packagist.org/packages/symfony/amphp-http-client-meta |
|
Do we need to document the symfony/amphp-http-client-meta package somewhere? |
|
Not sure, for userland, I think we already do the required runtime checks. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for amphp/http-client version 5 as a transport for our HttpClient component.
It started as a draft at nicolas-grekas#43, which helped spot that PHP is missing the capability to suspend fibers in destructors. This was reported as php/php-src#11389 and is being fixed at php/php-src#13460.
Since the fix for php-src is going to land on PHP 8.4, using amphp/http-client version 5 will require php >= 8.4.
The implementation duplicates the one we have for v4 with the needed changes to use the v5 API. The difference are not big in size of code, but they're very low level (generators vs fibers). That would be quite useless to factor IMHO.