Added option for not displaying a form-label by setting label to false. #5421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tml.twig Option for not displaying a label by setting label to false.
…tml.twig Fixed formatting & translation ..
|
The same should be done for the PHP rendering |
|
and this is breaking a lots of tests |
|
@BenjaminBeck can you update this PR to implement the feature in the PHP templates too ? |
|
@stof yes, i´ll do it. Can you please tell me where i can find the PHP templates? |
|
in FrameworkBundle |
|
@BenjaminBeck Do you have time to finish this PR? |
|
@fabpot Sorry, in the next 2-3 weeks i will have no time to finish it. |
|
closed in favor of #6262 |
fabpot
added a commit
that referenced
this pull request
Dec 11, 2012
This PR was merged into the master branch. Commits ------- d5426f0 [Form] Add tests to prove that label is not rendered when is marked as false 120547c [Form][TwigBridge] Don't set label attributes if is marked as not to be rendered [Form][FrameworkBundle] Add option to disable rendering of label for fields 36e4556 [Form] Option for not displaying a label by setting label to false. [Form] Fixed formatting & translation .. Discussion ---------- [Form] Added option for not displaying a form-label by setting label to false Bug fix: no Feature addition: yes Backwards compatibility break: no Symfony2 tests pass: yes Replaces: #5421 @fabpot @BenjaminBeck: I was just not sure what to do with "table based" forms, so I left `<td></td>` rendered when there is no label, because I'm not sure that we can hide it easily. --------------------------------------------------------------------------- by XWB at 2012-12-11T09:30:14Z :+1:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
....twig
Option for not displaying a label by setting label to false.