[DoctrineBridge] Fix deprecation warning with ORM 3 when guessing field lengths #54271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
reviewed
Mar 13, 2024
| @@ -141,8 +141,10 @@ public function guessMaxLength(string $class, string $property) | |||
| if ($ret && isset($ret[0]->fieldMappings[$property]) && !$ret[0]->hasAssociation($property)) { | |||
| $mapping = $ret[0]->getFieldMapping($property); | |||
|
|
|||
| if (isset($mapping['length'])) { | |||
| return new ValueGuess($mapping['length'], Guess::HIGH_CONFIDENCE); | |||
| $length = \is_array($mapping) ? $mapping['length'] : $mapping->length; | |||
There was a problem hiding this comment.
The previous logic allowed the length key not to be set. Your code would trigger a warning in that case.
There was a problem hiding this comment.
What if we tested for the actual class instead?
$length = $mapping instanceof FieldMapping ? $mapping->length : ($mapping['length'] ?? null);
derrabus
requested changes
Mar 13, 2024
fabpot
approved these changes
Mar 17, 2024
|
Thank you @eltharin. |
9aed443 to
43d9c19
Compare
This was referenced Apr 2, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[DoctrineBridge] prevent deprecated message #54255 for symfony 5.4