[Serializer] Fix: Report Xml warning/error instead of silently returning a wrong xml #54346
Conversation
9a5c7de to
0fa27a9
Compare
|
Others failure (especially lint) are unrelated. |
|
Don't we get an exception from ErrorHandler in debug mode at the moment? |
Yes, but not in production. So it silently return a wrong xml in prod.
Ok for 7.1. Should I do the PR like this or with an option to passe to the encoder @nicolas-grekas ? |
|
No options on my side. |
0fa27a9 to
2af997b
Compare
007f56d to
9516303
Compare
Done @nicolas-grekas :) |
| @@ -82,7 +82,12 @@ public function encode(mixed $data, string $format, array $context = []): string | |||
| $encoderIgnoredNodeTypes = $context[self::ENCODER_IGNORED_NODE_TYPES] ?? $this->defaultContext[self::ENCODER_IGNORED_NODE_TYPES]; | |||
| $ignorePiNode = \in_array(\XML_PI_NODE, $encoderIgnoredNodeTypes, true); | |||
| if ($data instanceof \DOMDocument) { | |||
| return $data->saveXML($ignorePiNode ? $data->documentElement : null); | |||
| set_error_handler(static function ($type, $message) { throw new NotEncodableValueException($message); }, \E_ERROR | \E_WARNING); | |||
There was a problem hiding this comment.
that doesn't work: php won't fallback on the previous handler for deprecation
instead, I suggest using the @ operator and using error_get_last to compute the exception message when needed
There was a problem hiding this comment.
$result = @$data->saveXML($ignorePiNode ? $data->documentElement : null);
if (false === $result) {
throw Exception();
}
doesn't cover all the case.
For instance
$dom = new DOMDocument();
$root = $dom->createElement('root');
$dom->appendChild($root);
$text = $dom->createTextNode("Invalid character: " . chr(7));
$root->appendChild($text);
$saved = $dom->saveXML();
// Check if saving was successful
if ($saved === false) {
echo "Error saving XML\n";
} else {
echo "XML saved successfully\n";
echo $saved;
}
gives
Warning: DOMDocument::saveXML(): xmlEscapeEntities : char out of range in /home/user/scripts/code.php on line 9
XML saved successfully
<?xml version="1.0"?>
<root></root>
There was a problem hiding this comment.
It should be better with 41c83a3 @nicolas-grekas
9c821fb to
4173286
Compare
|
Thank you @VincentLanglet. |
When
DomDocument::saveXMLencounter an error/warning, for examplethe method will return false or an empty/incomplete XML.
In case of
false, since symfony doesn't use strict type, it will be cast intostring(for 6.4+ version with native typehint) so theencodemethod will return an empty string.In case of empty/incomplete XML, symfony returns it as if, without any notice about the error/warning.
I think Symfony should not silently ignore such XML error when decoding.
Or should it be an option ?