-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Emoji] Add the gitlab locale #54441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamirault
commented
Mar 30, 2024
ce25a7c
to
b11877e
Compare
derrabus
approved these changes
Apr 1, 2024
stof
reviewed
Apr 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Support for gitlab
should also be added in the emojify
Twig filter
With actual PR #54432, no change is required in filter to support new "locale" |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 2, 2024
This PR was squashed before being merged into the 7.1 branch. Discussion ---------- [Emoji] Update slack data | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Update slack data to latest with make build Split #54441 in 2 PR as suggested in #54441 (comment) Commits ------- 1cc41cd [Emoji] Update slack data
b11877e
to
40a2dec
Compare
stof
approved these changes
Apr 3, 2024
Thank you @alamirault. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Emoji
Feature
❄️ Feature Freeze
Important Pull Requests to finish before the next Symfony "feature freeze"
Status: Reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gitlab has also its own emoji shortnames
https://docs.gitlab.com/ee/development/fe_guide/emojis.html
🤐
Github:
:zipper_mouth_face:
Gitlab:
:zipper_mouth:
(Like lyrixx, my most important PR of the year 😃 )