Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[DependencyInjection] Document BC break in UPGRADE file #54481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

OskarStark
Copy link
Contributor

Q A
Branch? 7.1
Bug fix? no
New feature? no
Deprecations? no
Issues Follows #52843
License MIT

@carsonbot carsonbot added this to the 7.1 milestone Apr 3, 2024
@OskarStark OskarStark added the ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" label Apr 3, 2024
Copy link
Member

@yceruto yceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oskar shouldn't the file to be updated be UPGRADE-7.1.md instead?

@OskarStark
Copy link
Contributor Author

You are right, I picked the wrong one 😅

@OskarStark OskarStark requested a review from yceruto April 4, 2024 14:10
Copy link
Member

@yceruto yceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Oskar!

@fabpot
Copy link
Member

fabpot commented Apr 5, 2024

Sorry, I'm late in the game here, but what is the rationale behind doing a BC break in 7.1?

@yceruto
Copy link
Member

yceruto commented Apr 5, 2024

Sorry, I'm late in the game here, but what is the rationale behind doing a BC break in 7.1?

Hey Fabien, we published this as a BC break because technically it is (we changed the behavior of the import() method under certain context/scope without deprecation path). However, actually, nobody can/should use the import() method in the prependExtension() because it's defective, appending config instead of prepending. That's why we were using the ContainerBuilder::prependExtensionConfig() until now (which is limited to an array of config).

Honestly, this BC break, in the end, doesn't feel like a real BC break to me, as the previous behavior was faulty and unwanted. However, it applies to the BC break rules, so we are documenting it as such.

More details can be found here #52789 and here #52843

Hope it's ok for you🤞

@fabpot
Copy link
Member

fabpot commented Apr 5, 2024

Sorry, I'm late in the game here, but what is the rationale behind doing a BC break in 7.1?

Hey Fabien, we published this as a BC break because technically it is (we changed the behavior of the import() method under certain context/scope without deprecation path). However, actually, nobody can/should use the import() method in the prependExtension() because it's defective, appending config instead of prepending. That's why we were using the ContainerBuilder::prependExtensionConfig() until now (which is limited to an array of config).

Honestly, this BC break, in the end, doesn't feel like a real BC break to me, as the previous behavior was faulty and unwanted. However, it applies to the BC break rules, so we are documenting it as such.

More details can be found here #52789 and here #52843

Hope it's ok for you🤞

Thank you for the clear explanation, that makes sense to me now.

@fabpot
Copy link
Member

fabpot commented Apr 5, 2024

Thank you @OskarStark.

@fabpot fabpot merged commit c35173c into symfony:7.1 Apr 5, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DependencyInjection ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" Status: Reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants