-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[DependencyInjection] Document BC break in UPGRADE file #54481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
OskarStark
commented
Apr 3, 2024
Q | A |
---|---|
Branch? | 7.1 |
Bug fix? | no |
New feature? | no |
Deprecations? | no |
Issues | Follows #52843 |
License | MIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oskar shouldn't the file to be updated be UPGRADE-7.1.md
instead?
You are right, I picked the wrong one 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Oskar!
Sorry, I'm late in the game here, but what is the rationale behind doing a BC break in 7.1? |
Hey Fabien, we published this as a BC break because technically it is (we changed the behavior of the Honestly, this BC break, in the end, doesn't feel like a real BC break to me, as the previous behavior was faulty and unwanted. However, it applies to the BC break rules, so we are documenting it as such. More details can be found here #52789 and here #52843 Hope it's ok for you🤞 |
Thank you for the clear explanation, that makes sense to me now. |
Thank you @OskarStark. |