Make ServiceSubscriberTrait compatible with AbstractController for Symfony 7 with strong types #54490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your change would be a breaking change for other users of the trait. I'm afraid, we cannot merge it. |
|
I see. Can we.. tag a higher version maybe? How is versioning and the bc-promise done for symfony/contracts? My issue appeared when upgrading from 6.4 to 7.0. I can easily work around it, but I thought an easier upgrade and more type safety in the trait might be nice. |
|
That's quite unfortunate! |
|
Oh lovely @nicolas-grekas, thanks for your much more complete solution in #54496, that looks great. |
fabpot
added a commit
that referenced
this pull request
Apr 5, 2024
…thodsSubscriberTrait (nicolas-grekas) This PR was merged into the 7.1 branch. Discussion ---------- [Contracts] Rename ServiceSubscriberTrait to ServiceMethodsSubscriberTrait | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | no | Deprecations? | yes | Issues | Fix #54490 | License | MIT As described in the linked PR, AbstractController is incompatible with ServiceSubscriberTrait because of the added type to the AbstractController::$container property, while ServiceSubscriberTrait's $container property cannot have a type without a BC break. There are two parts to this PR: - Deprecate ServiceSubscriberTrait in favor if ServiceMethodsSubscriberTrait, which declares the type of the $container property. The new name better conveys its purpose as a bonus. - Fix the incompatibility with AbstractController by removing the property declaration on ServiceSubscriberTrait. This means the trait will create a dynamic property. Those are deprecated, but since the trait is also deprecated, the upgrade path is clear. I also tried to improve the description of the trait in the meantime. /cc `@kbond` Commits ------- 8f47ced [Contracts] Rename ServiceSubscriberTrait to ServiceMethodsSubscriberTrait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have a class like this:
You get the following error in Symfony 7 with symfony/contracts 3.4.2:
ServiceSubscriberTrait::$containeris defined as:While
AbstractController::$containeris:This leads to the incompatible composition.
This PR would fix that, but I'm not sure which versions of symfony/framework-bundle and symfony/contracts to target. Maybe we should add a conflict against symfony/framework-bundle < 7.0 to symfony/contract's
composer.json.