Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Avoid bc break for AssciiSlugger::withEmoji in 7.1 #54499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

alexander-schranz
Copy link
Contributor

@alexander-schranz alexander-schranz commented Apr 5, 2024

Q A
Branch? 7.1
Bug fix? yes
New feature? no
Deprecations? no
Issues Related PR: #53096
License MIT

Avoid bc break for AssciiSlugger::withEmoji in 7.1.

Without a update from 7.0 -> 7.1 can crash application which are build with the withEmoji method.

Requirement could be removed again in Symfony 8.0.

@nicolas-grekas
Copy link
Member

While we try to not break existing apps, this aspect is not covered by the BC policy, and we do allow ourselves to remove a dep occasionally.
Here, I think we shouldn't do this change. withEmoji already throws an actionable exception when the dep is missing so it's pretty easy to spot and fix.

👎

@alexander-schranz
Copy link
Contributor Author

@nicolas-grekas what is the best way for software supporting a wider range of symfony versions like we have here in @sulu. For Symfony <=7.0 its for us still fine to call withEmoji part here: https://github.com/sulu/sulu/blob/1755685eea2c0c0afa0c4f43bc9fd1f1911d93a4/src/Sulu/Component/PHPCR/PathCleanup.php#L57. For 7.1 we should now again not call it, is there a detection to know if the symfony/string component is 7.1 or newer? so we have additional check if emoji package is installed?

@nicolas-grekas
Copy link
Member

You might want to do a feature check to detect string 7.1? Method AbstractUnicodeString::localeTitle() is new e.g.

@alexander-schranz
Copy link
Contributor Author

@nicolas-grekas Thank you will try that!

@alexander-schranz alexander-schranz deleted the patch-11 branch April 5, 2024 11:26
@alexander-schranz
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants