[TwigBundle] Deprecate base_template_class option
#54657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Apr 18, 2024
xabbuh
approved these changes
Apr 18, 2024
|
The deprecation should be documented in |
I will follow up with this shortly 😅 I just need to check how they are usually done :) |
1 task
base_template_class optionbase_template_class option
base_template_class optionbase_template_class option
fabpot
approved these changes
May 2, 2024
|
Thank you @Steveb-p. |
|
The tests needed a little adjustment: #54810 |
nicolas-grekas
added a commit
that referenced
this pull request
May 2, 2024
…e_class (derrabus) This PR was merged into the 7.1 branch. Discussion ---------- [TwigBundle] Fix deprecation warnings about base_template_class | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Follows #54657 | License | MIT Since #54657, TwigBundle uses its own deprecated option in non-legacy tests. This PR fixes this by testing that option and the triggered deprecation message in a separate test. Commits ------- 10d48cd [TwigBundle] Fix deprecation warnings about base_template_class
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://github.com/twigphp/Twig/blob/3.x/CHANGELOG#L222,
base_template_classoption has been removed from Twig 3.0.Symfony still allows to pass this configuration option via https://github.com/symfony/symfony/blob/7.1/src/Symfony/Bundle/TwigBundle/DependencyInjection/Configuration.php#L132, but there is of course no effect.
I think it would be good to deprecate it and prepare it's removal in 8.x? Since Symfony 7.x requires Twig 3.x.