[TypeInfo] Handle custom collection objects properly #54661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55fc9bf to
106fec9
Compare
106fec9 to
b2a7627
Compare
chalasr
approved these changes
Apr 18, 2024
welcoMattic
approved these changes
Apr 19, 2024
| @@ -164,7 +162,7 @@ private function getTypeFromNode(TypeNode $node, ?TypeContext $typeContext): Typ | |||
| default => $this->resolveCustomIdentifier($node->name, $typeContext), | |||
| }; | |||
|
|
|||
| if ($type instanceof ObjectType && \in_array($type->getClassName(), self::COLLECTION_CLASS_NAMES, true)) { | |||
| if ($type instanceof ObjectType && (is_a($type->getClassName(), \Traversable::class, true) || is_a($type->getClassName(), \ArrayAccess::class, true))) { | |||
There was a problem hiding this comment.
When using is_subclass_of, only subclasses will return true. And I think that it'd be great to be able to understand Traversable as a collection as well. WDYT?
There was a problem hiding this comment.
Not sure what you mean. is_subclass_of works with interfaces too: https://3v4l.org/bP6JN
There was a problem hiding this comment.
I guess what @mtarld means is that is_subclass_of(\Traversable::class, \Traversable::class); returns false: https://3v4l.org/1CbGV
There was a problem hiding this comment.
Exactly, thanks @xabbuh.
xabbuh
approved these changes
Apr 30, 2024
|
Thank you @mtarld. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Understand custom collection objects.