[PropertyInfo] Update DoctrineExtractor for new DBAL 4 BIGINT type #54694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
src/Symfony/Bridge/Doctrine/Tests/PropertyInfo/DoctrineExtractorTest.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
approved these changes
May 17, 2024
src/Symfony/Bridge/Doctrine/Tests/PropertyInfo/DoctrineExtractorTest.php
Outdated
Show resolved
Hide resolved
fabpot
approved these changes
May 17, 2024
|
Thank you @llupa. |
Merged
This was referenced Jun 2, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Considerations
This issue looks pretty straight forward, but it has had me running in circles not being sure how to exactly interpret it. The new return type to make it work with DBAL 4 is fine, but it is neither an intersection nor a union type, which will cause trouble for other libs if they do not explicitly check each.
There is not easy way to get which DBAL version is the extractor is running against, so trying to optimize the flow is tricky. I am opening this PR to have a starting point in the hopes that maintainers of this package have more historical context than me.
I have tried to document as much as possible about this in the issue linked above. 🍻