[AssetMapper] Check asset/vendor directory is writable #54724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failures unrelated (Predis nullables) |
src/Symfony/Component/AssetMapper/ImportMap/RemotePackageStorage.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
approved these changes
Apr 25, 2024
OskarStark
reviewed
Apr 25, 2024
src/Symfony/Component/AssetMapper/Tests/ImportMap/RemotePackageStorageTest.php
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Apr 25, 2024
rosier
reviewed
Apr 25, 2024
src/Symfony/Component/AssetMapper/ImportMap/RemotePackageStorage.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/AssetMapper/ImportMap/RemotePackageStorage.php
Outdated
Show resolved
Hide resolved
smnandre
commented
Apr 25, 2024
src/Symfony/Component/AssetMapper/ImportMap/RemotePackageStorage.php
Outdated
Show resolved
Hide resolved
rosier
approved these changes
Apr 26, 2024
OskarStark
approved these changes
Apr 26, 2024
fabpot
approved these changes
Apr 27, 2024
a583047 to
7c2da27
Compare
|
Thank you @smnandre. |
fabpot
added a commit
that referenced
this pull request
Aug 19, 2024
This PR was squashed before being merged into the 7.2 branch. Discussion ---------- [AssetMapper] Leverage Filesystem | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | Fix #... | License | MIT Continue the work started in #54173 & #54724 to replace php file functions (`mkdir`, `file_get_contents` , `file_put_contents`, `unlink`) by Filesystem methods Commits ------- a1bb5a2 [AssetMapper] Leverage Filesystem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💐