[Finder] Exclude relative to content root if prefixed / #54754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-davis
commented
Apr 27, 2024
phil-davis
commented
Apr 27, 2024
| ]), $finder->in(self::$tmpDir)->getIterator()); | ||
| } | ||
|
|
||
| public function testExcludeTopLevelOnly() |
There was a problem hiding this comment.
This is the new test case. The top-level foo has been excluded, but top/foo and top/foo/file.tmp are still included, which is what we want the new feature to do.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
Thanks for digging into the tests! I'll try to take a closer look at your PR in the week ahead. |
f144128 to
5349a03
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Fixes symfony#28158 Fixes symfony#47431 Related: symfony#26396 Related: symfony#9158 Related: symfony#28410
Signed-off-by: Josh Richards <[email protected]>
Co-authored-by: Oskar Stark <[email protected]>
5349a03 to
f1849f0
Compare
|
I have got this up-to-date with 7.2 branch, and cherry-picked all the code that I can see from #54752 CI passes. This is an example of the code plus tests that would work with 7.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some test enhancements ready to be used against code for this. So this PR to the 7.2 branch has:
top/foo/file.tmpmulti-level directory tree to the set of directories and files used by the Finder unit tests. That demonstrates the current behaviour, so we can ensure that the new feature does not introduce regressions. These tests pass with the existing 7.1 branch code./will then only exclude that folder name at the root (top) level of the tree./#54752