[HttpClient] deprecate setLogger() methods of decorating clients #54806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
May 2, 2024
| Q | A |
|---|---|
| Branch? | 7.1 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | yes |
| Issues | Fix #54674 (review) |
| License | MIT |
derrabus
approved these changes
May 2, 2024
|
Aren't those proxy methods tested anywhere? 🙈 |
fabpot
approved these changes
May 2, 2024
|
Thank you @xabbuh. |
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Oct 22, 2024
This PR was merged into the 7.1 branch. Discussion ---------- [HttpClient] Fix typo in deprecation message | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT Just a typo fix from #54806 This confused me initially because I thought I had to configure it on a wrapper, so add one more layer, but couldn't find a logging wrapper client.. Anyway `@xabbuh` one more question do I understand it correctly that if one just uses autowiring and the framework.http_client config to create a client, then the loggers will be set by default and nothing has to be done? No need to call setLogger explicitly on the client right? Commits ------- 648e531 Fix typo in deprecation message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.