[Stopwatch] Add ROOT constant to make it easier to reference#54854
Merged
fabpot merged 1 commit intosymfony:7.2from May 21, 2024
Merged
[Stopwatch] Add ROOT constant to make it easier to reference#54854fabpot merged 1 commit intosymfony:7.2from
ROOT constant to make it easier to reference#54854fabpot merged 1 commit intosymfony:7.2from
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you. Cheers! Carsonbot |
ROOT constant to make it easier to reference
Member
|
What about if we also add a method named |
xabbuh
reviewed
May 13, 2024
Contributor
Author
|
@xabbuh Updated as requested. |
xabbuh
approved these changes
May 13, 2024
fabpot
approved these changes
May 21, 2024
Member
|
Thank you @hacfi. |
Merged
ascirpus
pushed a commit
to ascirpus/stopwatch-fix
that referenced
this pull request
Dec 18, 2024
ascirpus
pushed a commit
to ascirpus/stopwatch-fix
that referenced
this pull request
Dec 18, 2024
…h a missing section
fabpot
added a commit
that referenced
this pull request
Dec 30, 2024
…fetch a mis… (Alex Niedre) This PR was merged into the 7.2 branch. Discussion ---------- [Stopwatch] bug #54854 undefined key error when trying to fetch a mis… | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | yes | New feature? |no | Deprecations? |no | Issues | Fix #54854 | License | MIT A minor bug was introduced in the related referenced issue which caused an unidentified key exception to trigger when referencing a section that was missing. Reproduced here, as an example: https://3v4l.org/OFFLB This MR addresses that and adds a simple test to prevent the same mistake in the future. Commits ------- c3cf577 bug #54854 [Stopwatch] undefined key error when trying to fetch a missing section
fabpot
added a commit
that referenced
this pull request
Dec 30, 2024
* 7.2: [SecurityBundle] Do not replace authenticators service by their traceable version [Finder] Fix using `==` as default operator in `DateComparator` bug #54854 [Stopwatch] undefined key error when trying to fetch a missing section [HttpFoundation] Avoid mime type guess with temp files in `BinaryFileResponse` choose the correctly cased class name for the MariaDB platform
Merged
OskarStark
added a commit
to OskarStark/symfony
that referenced
this pull request
Jan 2, 2025
* upstream/7.3: [SecurityBundle] Do not replace authenticators service by their traceable version reject URLs containing whitespaces [Finder] Fix using `==` as default operator in `DateComparator` Update validators.fa.xlf the "max" option can be zero [PropertyInfo] Remove `@internal` directives to allow extensions with no static-analysis errors [TypeInfo] Fix PHPDoc resolving of union with mixed [Security/Csrf] Trust "Referer" at the same level as "Origin" bug symfony#54854 [Stopwatch] undefined key error when trying to fetch a missing section [HttpClient] Fix a typo in NoPrivateNetworkHttpClient [HttpFoundation] Avoid mime type guess with temp files in `BinaryFileResponse` choose the correctly cased class name for the MariaDB platform fix test method parameter names
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just an DX improvement so you can reference the root section with
$stopwatch->getSectionEvents(Stopwatch::ROOT)instead of$stopwatch->getSectionEvents('__root__').