[Filesystem] Fix dumpFile stat failed error hitting custom handler
#54878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since symfony#54471, dumpFile will trigger a `fileperms(): stat failed` error when writing to a filename that does not yet exist. This was silenced from PHP's default handler with the `@` operator. However, the error is still passed to any custom handler that the application has registered, and can therefore cause exceptions or spurious logging depending on the implementation of the handler. The better solution, which is consistent with all other calls to native functions in this class, would be to use `self::box` to catch and ignore the potential error so that it never leaks outside this class.
|
As far as I can see the coding standards and test failures are unrelated to the change in this branch - but please let me know if you want any changes. |
|
The proposed solution works for me but:
This is still an error in the custom error handler if it doesn't respect the silencing of errors and should be fixed nonetheless as an error handler throwing no matter if the error was silenced can still throw too eagerly. |
That's probably true. At the same time, I don't think a library should be relying on the silencing operator to suppress errors that are emitted during expected usage of a method - in particular if it hasn't done so in the past, since this might break existing applications where the over-eager throw has not historically caused any problems. |
xabbuh
approved these changes
May 13, 2024
stat failed error hitting custom handlerstat failed error hitting custom handler
stat failed error hitting custom handlerstat failed error hitting custom handler
|
Thank you @acoulton. |
Merged
This was referenced Jun 2, 2024
Merged
Merged
Merged
github-merge-queue bot
pushed a commit
to Lendable/composer-license-checker
that referenced
this pull request
Jun 3, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [symfony/filesystem](https://symfony.com) ([source](https://togithub.com/symfony/filesystem)) | `6.4.6` -> `6.4.8` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>symfony/filesystem (symfony/filesystem)</summary> ### [`v6.4.8`](https://togithub.com/symfony/filesystem/releases/tag/v6.4.8) [Compare Source](https://togithub.com/symfony/filesystem/compare/v6.4.7...v6.4.8) **Changelog** (symfony/filesystem@v6.4.7...v6.4.8) - bug [symfony/symfony#54878](https://togithub.com/symfony/symfony/issues/54878) \[Filesystem] Fix dumpFile `stat failed` error hitting custom handler (@​acoulton) - bug [symfony/symfony#54759](https://togithub.com/symfony/symfony/issues/54759) \[Filesystem] better distinguish URL schemes and Windows drive letters ([@​xabbuh](https://togithub.com/xabbuh)) ### [`v6.4.7`](https://togithub.com/symfony/filesystem/releases/tag/v6.4.7) [Compare Source](https://togithub.com/symfony/filesystem/compare/v6.4.6...v6.4.7) **Changelog** (symfony/filesystem@v6.4.6...v6.4.7) - bug [symfony/symfony#54471](https://togithub.com/symfony/symfony/issues/54471) \[Filesystem] Strengthen the check of file permissions in `dumpFile` (@​alexandre-daubois) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Lendable/composer-license-checker). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM3Ny44IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #54471, dumpFile will trigger a
fileperms(): stat failederror when writing to a filename that does not yet exist. This was silenced from PHP's default handler with the@operator.However, the error is still passed to any custom handler that the application has registered, and can therefore cause exceptions or spurious logging depending on the implementation of the handler.
The better solution, which is consistent with all other calls to native functions in this class, would be to use
self::boxto catch and ignore the potential error so that it never leaks outside this class.