[DependencyInjection] Fix binding parameters with default empty values #57186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see this bug fix did not make it to the 7.2.0 release 😢 Can it be merged so that it can ship in 7.2.1? |
| } | ||
| if (\array_key_exists($parameter->name, $arguments) && '' !== $arguments[$parameter->name]) { | ||
|
|
||
| if (\array_key_exists($key, $arguments) && !\in_array($arguments[$key], ['', null, []], true)) { |
There was a problem hiding this comment.
I'm not sure this makes sense: the empty string is a special case needed when loading from XML, but the others can only be defined by explicit definition.
It's also suspicious to me to change the DI component for an issue with the serializer one.
There was a problem hiding this comment.
@nicolas-grekas Yeah, I was way off with this solution, see #57273.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused by #54791 and #52917 (sort of). The main problem is that once the default value of
nullwas added, the binding didn't resolve properly. Theserializer.normalizer.property, and possibly others, have the same problem.