[ErrorHandler] Fix rendered exception code highlighting on PHP 8.3 #57355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Jun 15, 2024
|
Thank you @tscni. |
This was referenced Jun 28, 2024
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#51586 made some mistakes when fixing the use of
highlight_file()for PHP 8.3:<span>were changed to<code>\nwhen splitting the highlighting across multiple lines , including those inside tags, breaking the highlighting entirelyThe first two are easy to fix.
The latter one not so much without CSS adjustments. But just changing
white-space: nowraptowhite-space: prewould remove the need for that. I'm a bit worried about side effects though and I'm not sure ifCodeExtensionuses separate styling somewhere, but I can't find anything problematic at least.A test would be a bit cumbersome to add for this, so unless very much preferred I'd rather not spend the time on it.
But at least in manual tests this resolved all the highlighting issues.