Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[AssetMapper] Skip test with chmod failing on Windows #57375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[AssetMapper] Skip test with chmod failing on Windows #57375

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a49b501
[AssetMapper] Skip test with `chmod` failing on Windows
smnandre Jun 12, 2024
e58b102
Test my theory
smnandre Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[AssetMapper] Skip test with chmod failing on Windows
  • Loading branch information
@smnandre
smnandre committed Jun 12, 2024
commit a49b501034bc0f3e4a78da4564e72caf40e274bc
4 changes: 4 additions & 0 deletions src/Symfony/Component/AssetMapper/Tests/ImportMap/RemotePackageStorageTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,10 @@ public function testGetStorageDir()

public function testSaveThrowsWhenVendorDirectoryIsNotWritable()
{
if ('\\' === \DIRECTORY_SEPARATOR) {
$this->markTestSkipped('chmod is not supported on Windows');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still necessary with the change done in the Filesystem component?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think i missed these changes... :/

KInda still think this is the main reason... but of course if ij the meantime something has been fixed on FS ... 😶‍🌫️

e58b102

}

$this->filesystem->mkdir($vendorDir = self::$writableRoot.'/assets/acme/vendor');
$this->filesystem->chmod($vendorDir, 0555);

Expand Down