Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Serializer][Validator] Fix propertyPath when normalize constraint violations with MetadataAwareNameConverter #57392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
antten wants to merge 3 commits into
base: 6.4
Choose a base branch
from
Open

[Serializer][Validator] Fix propertyPath when normalize constraint violations with MetadataAwareNameConverter #57392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7711c53
[Serializer][Validator] Fix propertyPath when normalize constraint vi…
antten Jun 14, 2024
fbaf268
[Serializer][Validator] Fix static analysis report.
antten Jun 14, 2024
a952a70
[Serializer][Validator] Revert fabbot CS fix unrelated to the PR
antten Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/Symfony/Component/Serializer/Normalizer/ConstraintViolationListNormalizer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,16 @@ public function normalize(mixed $object, ?string $format = null, array $context
$violations = [];
$messages = [];
foreach ($object as $violation) {
$propertyPath = $this->nameConverter ? $this->nameConverter->normalize($violation->getPropertyPath(), null, $format, $context) : $violation->getPropertyPath();
$propertyPath = $violation->getPropertyPath();

if (null !== $this->nameConverter) {
$propertyPath = $this->nameConverter->normalize(
$violation->getPropertyPath(),
\is_object($violation->getRoot()) ? \get_class($violation->getRoot()) : null,
$format,
$context
);
}

$violationEntry = [
'propertyPath' => $propertyPath,
Expand Down
34 changes: 34 additions & 0 deletions src/Symfony/Component/Serializer/Tests/Normalizer/ConstraintViolationListNormalizerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,13 @@
namespace Symfony\Component\Serializer\Tests\Normalizer;

use PHPUnit\Framework\TestCase;
use Symfony\Component\Serializer\Mapping\ClassMetadata;
use Symfony\Component\Serializer\Mapping\Factory\ClassMetadataFactory;
use Symfony\Component\Serializer\Mapping\Loader\AttributeLoader;
use Symfony\Component\Serializer\NameConverter\CamelCaseToSnakeCaseNameConverter;
use Symfony\Component\Serializer\NameConverter\MetadataAwareNameConverter;
use Symfony\Component\Serializer\Normalizer\ConstraintViolationListNormalizer;
use Symfony\Component\Serializer\Tests\Dummy\DummyClassOne;
use Symfony\Component\Validator\Constraints\NotNull;
use Symfony\Component\Validator\ConstraintViolation;
use Symfony\Component\Validator\ConstraintViolationList;
Expand Down Expand Up @@ -113,6 +118,35 @@ public function testNormalizeWithNameConverter()
$this->assertEquals($expected, $normalizer->normalize($list));
}

public function testNormalizeWithMetadataAwareNameConverter()
{
$attributeLoader = new AttributeLoader();
$attributeLoader->loadClassMetadata(new ClassMetadata(DummyClassOne::class));

$nameConverter = new MetadataAwareNameConverter(new ClassMetadataFactory($attributeLoader));
$normalizer = new ConstraintViolationListNormalizer([], $nameConverter);

$list = new ConstraintViolationList([
new ConstraintViolation('too long', 'a', [], new DummyClassOne(), 'code', ''),
]);

$expected = [
'type' => 'https://symfony.com/errors/validation',
'title' => 'Validation Failed',
'detail' => 'identifier: too long',
'violations' => [
[
'propertyPath' => 'identifier',
'title' => 'too long',
'template' => 'a',
'parameters' => [],
],
],
];

$this->assertEquals($expected, $normalizer->normalize($list));
}

/**
* @dataProvider payloadFieldsProvider
*/
Expand Down