Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[SecurityBundle] Add provider XML attribute to the authenticators it’s missing from #57467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

MatTheCat
Copy link
Contributor

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Issues N/A
License MIT

This PR fixes the issues found while investigating #57463 (but not #57463 itself as I’m not sure about its impact):

  • provider attribute is missing for several authenticators in the XSD
  • fixtures use a form_login instead of the form-login authenticator
  • fixtures use user-checker as a firewall element rather than attribute

@nicolas-grekas
Copy link
Member

Thank you @MatTheCat.

@nicolas-grekas nicolas-grekas merged commit 7085623 into symfony:5.4 Jun 21, 2024
10 of 12 checks passed
@MatTheCat MatTheCat deleted the security-xml branch June 21, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants