[Routing] Discard in-memory cache of routes when writing the file-based cache #57645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
approved these changes
Jul 4, 2024
OskarStark
approved these changes
Jul 4, 2024
|
Thank you @mpdude. |
This was referenced Jul 26, 2024
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Routerhas aprivate static ?array $cachefield that it uses to cache compiled route collections in the case that OpCache is not available to cache the file-based cache already. This is somewhat a poor man's Opcache replacement, useful e. g. for speedups during (functional) tests.\Symfony\Component\Config\ResourceCheckerConfigCache::writecontains special code to make sure the OpCache will reload files after they have been written, but thestaticproperty kind of "hides" this feature.With this PR, the
staticcache entry is cleared as well.